Added Migurski/ OSM Terrain for the US#406
Added Migurski/ OSM Terrain for the US#406rsignell-usgs wants to merge 4 commits intoSciTools:masterfrom
Conversation
|
👍 - it'd be useful to put a docstring on the class, just to clarify that this is only defined over the US (sadly, as the rendering is beautiful). I certainly think we can streamline the construction of some of these services - I'm not too worried about doing that in this PR, but please feel free to investigate as a follow on. There are a few PEP8 test failiures from this PR: |
|
Okay, updated for PEP8 compliance and added a docstring describing this US coverage. Note that the tools for creating these tiles are at https://github.com/migurski/DEM-Tools and at least the Canadians have used them: migurski/DEM-Tools#4 |
|
Should we call this OSMTerrain or USTerrain instead of StamenTerrain? |
There has to be a better way.
|
Are there python editors that test pep8 compliance? It seems like using Travis CI to find pep8 errors is a bit of a waste... |
|
@pelson, So I see that this PR still fails, but is this something I need to fix? |
|
The local tests you run before submitting your PR should pick up the PEP8 errors so you can get them cleared up before you push your branch. You can also run pep8 yourself ( to just check the lines you changed relative to the upstream master branch. You can configure many editors to do PEP8 checking, I generally don't bother and instead rely on the locally run test suite and/or manual checking, but that is personal preference. |
I think the Google tiles have changed (ocean names have moved position) since the static image was created. I don't believe this is due to your code so you are safe to ignore it. |
|
Thanks for the tutorage, @ajdawson ! |
|
so okay to merge? |
|
Is the "build.out" file supposed to be included? |
|
Thanks @rsignell-usgs - I've rebased and squashed these onto master as 727d0ed. (I've assumed "build.out" was just a mistake so it's not included.) |
Since I work for the USGS, I thought it would be cool to add the US Terrain tile map service that uses the USGS National Elevation Database to create this cool terrain tile map service.
Example:
http://nbviewer.ipython.org/github/rsignell-usgs/notebook/blob/master/Cartopy/Cartopy_terrain.ipynb
I'm not sure about the best name for this new class. I called it "StamenTerrain" instead of "Terrain" because stamen is providing this terrain service and there could be others. But I yield to your judgement here.
BTW, Maybe since there are a lot of these services that follow the same pattern
http://wiki.openstreetmap.org/wiki/List_of_OSM_based_Services
would it be useful to have a generic class for these services that a user could instantiate with a base url?